Skip to content

Commit

Permalink
Set Python bindings to OFF by default (#2002)
Browse files Browse the repository at this point in the history
Users building the project by following the README may not need the
Python bindings, so we shouldn't recommend building them by default.

#2001
  • Loading branch information
mlevesquedion authored Feb 9, 2024
1 parent 2ed1466 commit e191eb4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Here's how to build the StableHLO repo on Linux or macOS:
5. Configure and build MLIR:

```sh
MLIR_ENABLE_BINDINGS_PYTHON=ON build_tools/build_mlir.sh ${PWD}/llvm-project/ ${PWD}/llvm-build
MLIR_ENABLE_BINDINGS_PYTHON=OFF build_tools/build_mlir.sh ${PWD}/llvm-project/ ${PWD}/llvm-build
```

This will take a considerable amount of time. For example, on a MacBook Pro
Expand All @@ -86,7 +86,7 @@ Here's how to build the StableHLO repo on Linux or macOS:
-DLLVM_ENABLE_LLD="$LLVM_ENABLE_LLD" \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DSTABLEHLO_ENABLE_BINDINGS_PYTHON=ON \
-DSTABLEHLO_ENABLE_BINDINGS_PYTHON=OFF \
-DMLIR_DIR=${PWD}/../llvm-build/lib/cmake/mlir

cmake --build .
Expand Down

0 comments on commit e191eb4

Please sign in to comment.