baresip: Use UCI for basic service configuration #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jslachta, are any issues with the PR ? I am running those for about 2 months now on my systems just fine. |
|
Hi @dddaniel, I am sorry for the delay. Only one objection - please, bump PKG_RELEASE variable, since it changes package checksum. Otherwise it looks good. Thank you. |
The baresip init script is changed to use UCI instead of the debian style /etc/default basic service configuration. A uci-defaults script is added to create a basic UCI config: -- config baresip main option enable 0 option options '' -- With this change an issues is also resolved, on which the baresip service doesn't start due to the baresip user not being the owner of the /etc/baresip configuration directory. Additionally a reload_config trigger is added for baresip. Signed-off-by: Daniel Danzberger <[email protected]>
jslachta
approved these changes
Jan 6, 2025
|
Thank you, @dddaniel . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The baresip init script is changed to use UCI instead of the debian style /etc/default basic service configuration.
A uci-defaults script is added to create a basic UCI config: --
config baresip main
option enable 0
option options ''
With this change an issues is also resolved, on which the baresip service doesn't start due to the baresip user not being the owner of the /etc/baresip configuration directory.
Additionally a reload_config trigger is added for baresip.
Run tested on X86.