sofia-sip: removed "--disable-stun" #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need stun enabled to compile svd. Signed-off-by: Luca Olivetti <[email protected]>
jslachta
approved these changes
Sep 21, 2024
|
I don't see a point for this. The software that is using this is not in this repo. The user can keep the change locally. Not needed for openwrt telephony.
Kind regards,
Seb
|
|
But why |
|
Am 21. September 2024 19:25:46 UTC schrieb Luca Olivetti ***@***.***>:
But why `--disable-stun `in the first place?
Freeswitch doesn't need it for STUN.
|
|
But would it work with it? It only adds 540 bytes to the compiled library. |
|
Ah, so it's only a tiny increase. Thanks for pointing that out. Then I don't mind. Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @micmac1
Run tested: (mips, Astoria Networks ARV7518PW, OpenWrt 23.05.4 r24012-d8dd03c46f , sip registration and made a test sip call)
Description:
I'm trying to update my svd package for OpenWrt 23.05.4. To compile it I need stun enabled.
I'm working on a test repository here whereIn my repository I adopted this version of the Makefile.