Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove branching to mitigate flaky used cells #866

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

nyunyunyunyu
Copy link
Contributor

@nyunyunyunyu nyunyunyunyu commented Nov 26, 2024

I think most flakiness(but not sure if it's all) is from nondeterministic pow_witness.
This fix cannot fully avoid flakiness. For example, here then/else branch have different numbers of instructions because then has 1 extra JAL. Therefore flakiness is natural. We can avoid distraction by not showing a small % of used cell changes.

closes INT-2323

Copy link

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms instance alloc
base64_json_program
2
(+14,572 [+0.1%])
14,996,988
(+42 [+0.0%])
217,352
(-35.0 [-1.4%])
2,489.0
-
-
-
-
64cpu-linux-arm64 mimalloc
fibonacci_program
2
(-4,740 [-0.0%])
51,512,218
1,500,219
(+17.0 [+0.3%])
6,399.0
-
-
-
-
64cpu-linux-arm64 mimalloc
fibonacci_program
2
(-2,376 [-0.0%])
51,512,218
1,500,219
(-454.0 [-6.3%])
6,746.0
-
-
-
-
64cpu-linux-x64 jemalloc
regex_program
2
(+15,167 [+0.0%])
238,565,138
(+22 [+0.0%])
4,181,072
(-255.0 [-0.9%])
26,923.0
-
-
-
-
64cpu-linux-arm64 mimalloc
verify_fibair
2
(-11,352 [-0.1%])
8,294,755
(-645 [-0.3%])
198,497
(-42.0 [-2.9%])
1,426.0
-
-
-
-
64cpu-linux-arm64 mimalloc

Commit: 876552a

Benchmark Workflow

Copy link

linear bot commented Nov 26, 2024

@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review November 26, 2024 05:44
@nyunyunyunyu nyunyunyunyu changed the title [fix] Remove branching to avoid flaky used cells [fix] Remove branching to mitigate flaky used cells Nov 26, 2024
@nyunyunyunyu nyunyunyunyu enabled auto-merge (squash) November 26, 2024 05:46
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if there was flakiness before we turned on grinding, but let's see

@nyunyunyunyu nyunyunyunyu merged commit 08e6e94 into main Nov 26, 2024
12 checks passed
@nyunyunyunyu nyunyunyunyu deleted the fix/flaky-used-cells branch November 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants