[fix] Remove branching to mitigate flaky used cells #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most flakiness(but not sure if it's all) is from nondeterministic
pow_witness
.This fix cannot fully avoid flakiness. For example, here
then
/else
branch have different numbers of instructions becausethen
has 1 extraJAL
. Therefore flakiness is natural. We can avoid distraction by not showing a small % of used cell changes.closes INT-2323