-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] polish declare
/init
macros (rename and move to one place etc)
#1262
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Currently the tests aren't working because it tries to find the |
Or we can make these use relative paths, not git. @jonathanpwang do you know if there is any reason why examples/pairing/Cargo.toml uses git at |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Just to make it match how it would be used outside of this repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I requested some changes to folder names and also the macro re-export alias
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, overall great cleanup and new readmes are very helpful
Commit: d883e92 |
Merge after revm/reth-bench are synced |
This resolves INT-3058 and INT-3060.
All three macro crates (moduli, complex, sw) are now in extensions/extension-algebra-macros. Each of them now has a
README.md
, which docs/repo/layout.md refers to.