Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] polish declare/init macros (rename and move to one place etc) #1262

Merged
merged 14 commits into from
Jan 23, 2025

Conversation

Golovanov399
Copy link
Contributor

This resolves INT-3058 and INT-3060.

All three macro crates (moduli, complex, sw) are now in extensions/extension-algebra-macros. Each of them now has a README.md, which docs/repo/layout.md refers to.

This comment has been minimized.

@Golovanov399 Golovanov399 requested a review from luffykai January 23, 2025 17:21

This comment has been minimized.

@Golovanov399
Copy link
Contributor Author

Currently the tests aren't working because it tries to find the openvm-algebra-moduli-macros crate at https://github.com/openvm-org/openvm.git, which is not there yet. I think they should pass after merge

@Golovanov399
Copy link
Contributor Author

Or we can make these use relative paths, not git. @jonathanpwang do you know if there is any reason why examples/pairing/Cargo.toml uses git at openvm-algebra-moduli-macros = { git = "https://github.com/openvm-org/openvm.git" }?

This comment has been minimized.

This comment has been minimized.

@jonathanpwang
Copy link
Contributor

Or we can make these use relative paths, not git. @jonathanpwang do you know if there is any reason why examples/pairing/Cargo.toml uses git at openvm-algebra-moduli-macros = { git = "https://github.com/openvm-org/openvm.git" }?

Just to make it match how it would be used outside of this repo

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some changes to folder names and also the macro re-export alias

This comment has been minimized.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except comments

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, overall great cleanup and new readmes are very helpful

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+12 [+0.5%]) 2,351 513,369 19,358,282 - - -
fibonacci_program (-49 [-0.8%]) 6,061 1,500,092 51,484,605 - - -
regex_program (-73 [-0.4%]) 18,484 4,139,836 163,833,427 - - -
ecrecover_program (-13 [-0.5%]) 2,595 284,561 15,054,935 - - -

Commit: d883e92

Benchmark Workflow

@jonathanpwang
Copy link
Contributor

Merge after revm/reth-bench are synced

@jonathanpwang jonathanpwang merged commit 354dd06 into main Jan 23, 2025
16 of 17 checks passed
@jonathanpwang jonathanpwang deleted the feat/polerowanie-makr branch January 23, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants