Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] modular setup macro padding #1252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

luffykai
Copy link
Contributor

Currently, if the modulus has 40 bytes, the blocksize is 8 and final number of limbs is still 40.
But we can't really do 40, as the adapter is either 32 or 48. Change the macro to match that logic

@luffykai luffykai changed the title [fix\ modular setup macro padding [fix] modular setup macro padding Jan 22, 2025
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-63 [-2.7%]) 2,233 513,774 19,386,023 - - -
fibonacci_program (+35 [+0.6%]) 6,060 1,500,137 51,487,838 - - -
regex_program (-34 [-0.2%]) 17,829 4,190,904 165,010,909 - - -
ecrecover_program (+18 [+0.7%]) 2,613 285,401 15,075,033 - - -

Commit: f0502f0

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant