[feat] support execute until segment #1251
Open
+85
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luffykai
force-pushed
the
lunkai/exec-1seg
branch
from
7e0087e to
3eedf33
Compare
Commit: 3eedf33 |
| loop { | ||
| let mut one_segment_result = | ||
| self.execute_until_segment(exe.clone(), memory, streams, segment_idx, pc)?; | ||
| streams = one_segment_result.segment.chip_complex.take_streams(); |
There was a problem hiding this comment.
this is unrelated, but could you see if you can take the cycle tracker from the previous segment and pass it to the next segment? currently it's causing multi-segment flamegraphs to break
jonathanpwang
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix INT-3004