-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[perf] Optimize FriReducedOpeningChip #1248
Open
nyunyunyunyu
wants to merge
6
commits into
main
Choose a base branch
from
feat/opt-fri-reduce
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyunyunyunyu
added
run-benchmark
triggers benchmark workflows on the pr
run-benchmark-e2e
labels
Jan 22, 2025
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/opt-fri-reduce
branch
2 times, most recently
from
January 22, 2025 16:24
edc6db6
to
259a25f
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/opt-fri-reduce
branch
2 times, most recently
from
January 22, 2025 17:13
6258838
to
ffff287
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/opt-fri-reduce
branch
from
January 22, 2025 17:47
ffff287
to
b1e410c
Compare
nyunyunyunyu
force-pushed
the
feat/opt-fri-reduce
branch
from
January 22, 2025 17:59
b1e410c
to
82f0e94
Compare
This comment has been minimized.
This comment has been minimized.
Can you also update the ISA documentation? |
yi-sun
reviewed
Jan 23, 2025
jonathanpwang
changed the title
[chore] Optimize FriReducedOpeningChip
[perf] Optimize FriReducedOpeningChip
Jan 23, 2025
nyunyunyunyu
force-pushed
the
feat/opt-fri-reduce
branch
from
January 23, 2025 06:47
82f0e94
to
ae71e73
Compare
This comment has been minimized.
This comment has been minimized.
yi-sun
reviewed
Jan 23, 2025
Commit: 0ff18c5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes INT-3055
Reduced # of columns of
FriReducedOpeningChip
from 64 to 26. A side effect is that we use a more efficient way to computealpha_pow
.Notes for reviewers:
extensions/native/circuit/src/fri/mod.rs
. I rewrite everything so diff view is not helpful.WorkloadCols
/Instruction1Cols
/Instruction2Cols
. I use lots of static assertions in order to guarantee that some columns in these variants are aligned.WorkloadCols
:length
rows ofWorkloadCols
.a
/b
from memory and writelocal.result * local.alpha + b - a
intonext.result
Instruction1Cols
:Instruction1Cols
after allWorkloadCols
.a_ptr
/b_ptr
/length
/alpha
and writelocal.result
intolocal.result_ptr
.a_ptr
/b_ptr
/alpha
inWorkloadCols
above are from this row.Instruction2Cols
:Instruction2Cols
afterInstruction1Cols
.fib_e2e before this PR(ref):
fib_e2e after this PR(ref):
Proof time of some verifier drops ~30% but others keep same. I'm surprised
halo2_outer
proof time increases because the number column decreases.