Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache alpha powers in static verifier #1238

Merged
merged 10 commits into from
Jan 21, 2025
Merged

feat: cache alpha powers in static verifier #1238

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e090128
feat: use horner eval in static verifier
yi-sun Jan 19, 2025
cba5a2d
feat: optimize for loop
yi-sun Jan 19, 2025
4c8135c
feat: remove unnecessary expr
yi-sun Jan 19, 2025
c31ceac
feat: allocate alpha_c_pow less
yi-sun Jan 19, 2025
9b63711
feat: try different order
yi-sun Jan 19, 2025
2dd3b28
feat: cache alpha pow
yi-sun Jan 19, 2025
d64dafd
feat: add missing alpha
yi-sun Jan 19, 2025
43b4d10
feat: optimize alpha caching
yi-sun Jan 19, 2025
543328c
feat: minor optimization for alpha caching
yi-sun Jan 19, 2025
0116fae
fix: bound
yi-sun Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions extensions/native/recursion/src/fri/two_adic_pcs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ pub fn verify_two_adic_pcs<C: Config>(
builder.set_value(&alpha_pow, j, one_ef);
}
}
let mut alpha_pow_cache = Vec::new();

compile_zip!(builder, query_proof.input_proof, rounds).for_each(|ptr_vec, builder| {
let batch_opening = builder.iter_ptr_get(&query_proof.input_proof, ptr_vec[0]);
Expand Down Expand Up @@ -203,10 +204,34 @@ pub fn verify_two_adic_pcs<C: Config>(
let p_at_x = builder.get(&mat_opening, t);
let p_at_z = builder.get(&ps_at_z, t);

builder.assign(&n, cur_alpha_pow * (p_at_z - p_at_x) + n);
builder.assign(&cur_alpha_pow, cur_alpha_pow * alpha);
if ptr_vec[0].value() == 0 {
if t.value() == 0 && alpha_pow_cache.is_empty() {
alpha_pow_cache.push(builder.constant(C::EF::ONE));
} else if t.value() >= alpha_pow_cache.len() {
let next: Ext<_, _> = builder.uninit();
alpha_pow_cache.push(next);
builder.assign(
&alpha_pow_cache[t.value()],
alpha_pow_cache[t.value() - 1] * alpha,
);
}
}
builder
.assign(&n, (p_at_z - p_at_x) * alpha_pow_cache[t.value()] + n);
});
builder.assign(&cur_ro, cur_ro + n / (z - x));
if ps_at_z.len().value() >= alpha_pow_cache.len() {
let next: Ext<_, _> = builder.uninit();
alpha_pow_cache.push(next);
builder.assign(
&alpha_pow_cache[ps_at_z.len().value()],
alpha_pow_cache[ps_at_z.len().value() - 1] * alpha,
);
}
builder.assign(&cur_ro, cur_ro + cur_alpha_pow * n / (z - x));
builder.assign(
&cur_alpha_pow,
cur_alpha_pow * alpha_pow_cache[ps_at_z.len().value()],
);
} else {
let mat_ro = builder.fri_single_reduced_opening_eval(
alpha,
Expand Down