chore: clean up for loops and breaks #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 1b9f504 |
| @@ -815,7 +781,8 @@ impl<F: PrimeField32 + TwoAdicField, EF: ExtensionField<F> + TwoAdicField> IfCom | |||
| } | |||
| } | |||
|
|
|||
| // Zipped for loop -- loop extends over the first entry in starts and ends | |||
| // Zipped for loop -- loop extends over the first entry in starts and end0 | |||
| // ATTENTION: starting with starts[0] > end0 will lead to undefined behavior. | |||
There was a problem hiding this comment.
This is a bit scary in the VM case: is there any way we could prevent this at compile time?
Is it basically only used to iterate through arrays and in the range(0, ?) cases (where it's safe)?
There was a problem hiding this comment.
Correct, only via builder.zip() and builder.range()
jonathanpwang
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder.iter()compile_zip!toiter_zip!Closes INT-3015