feat: Customizable static verifier public values handler #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@nyunyunyunyu please review |
kk |
| @@ -127,8 +127,7 @@ impl Halo2WrapperProvingKey { | |||
| ); | |||
| assert_eq!( | |||
| self.pinning.metadata.num_pvs[0], | |||
| // 12 is the number of public values for the accumulator | |||
| snark_to_verify.instances[0].len() + 12 | |||
| snark_to_verify.instances[0].len() + 12, | |||
There was a problem hiding this comment.
why delete this comment?
There was a problem hiding this comment.
sorry, i had added and removed something and the comment went with it. will restore the comment
yes, will add one |
This comment has been minimized.
This comment has been minimized.
Commit: 846d202 |
|
@nyunyunyunyu added test that shows how it's used (same pattern in the other repo PR): https://github.com/openvm-org/openvm/pull/1226/files#diff-e8080e6de56d5f572a1f800ab4ebba8d622c988ae8e5bce485c5067ca5528bfaR267 |
nyunyunyunyu
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to optionally customize the static verifier's public values handler