fix q max overflow bits (#722)

openvm-org · Oct 30, 2024 · e02416f · e02416f
1 parent 5ebc699
commit e02416f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/circuits/primitives/src/bigint/check_carry_mod_to_zero.rs b/circuits/primitives/src/bigint/check_carry_mod_to_zero.rs
@@ -77,10 +77,12 @@ impl<AB: InteractionBuilder> SubAir<AB> for CheckCarryModToZeroSubAir {
                 is_valid,
             );
         }
-        let overflow_q = OverflowInt::<AB::Expr>::from_var_vec::<AB, AB::Var>(
-            quotient,
-            self.check_carry_to_zero.limb_bits,
-        );
+        let limb_bits = self.check_carry_to_zero.limb_bits;
+        let overflow_q = OverflowInt::<AB::Expr> {
+            limbs: quotient.iter().map(|&x| x.into()).collect(),
+            max_overflow_bits: limb_bits + 1, // q can be negative, so this is the constraint we have when range check.
+            limb_max_abs: 1 << limb_bits,
+        };
         let p_limbs = self
             .modulus_limbs
             .iter()