[Tokenizers] Added support for conda-forge, archive installations #782
Conversation
github-actions
bot
added
category: build
ilya-lavrenov
force-pushed
the
conda-forge
branch
from
b43b517 to
4511001
Compare
| sys.exit(f"Error: extension does not support the platform {sys.platform}") | ||
|
|
||
| # conda-forge case | ||
| conda_forge_lib_path = Path(os.path.join(os.path.dirname(__file__), "..", "..", "..")) |
There was a problem hiding this comment.
Maybe it would be better to search extension in the os.environ["PATH"]?
There was a problem hiding this comment.
if conda env is not activated, it will not work.
There was a problem hiding this comment.
Is there a scenario when a user installs openvino_tokenizers with conda, but uses it without activating any conda env?
There was a problem hiding this comment.
potentially I can use /abs/path/to/conda/env/python and openvino_tokenizers will find libraries.
There was a problem hiding this comment.
It should be more robust. We had problems with pip install -e . when trying to find libraries relative to the __file__ path. There may be similar problems with a conda installation.
There was a problem hiding this comment.
conda does not work in editable mode
renamed component core => tokenizers
ilya-lavrenov
force-pushed
the
conda-forge
branch
from
1aec93c to
fb7f895
Compare
modules/custom_operations/user_ie_extensions/tokenizer/python/openvino_tokenizers/__init__.py
Show resolved
Hide resolved
modules/custom_operations/user_ie_extensions/tokenizer/python/openvino_tokenizers/__init__.py
Show resolved
Hide resolved
apaniukov
changed the title
I'll merge as is and fix comments in next PR #784 |
No description provided.