[NVIDIA] Update setup.py script #751
Conversation
github-actions
bot
added
category: NVIDIA plugin
redradist
force-pushed
the
refactoring/update-setup-py-script
branch
from
abcf9d5 to
1f3b4dc
Compare
redradist
force-pushed
the
refactoring/update-setup-py-script
branch
from
1f3b4dc to
6b7bd73
Compare
| f'-DWHEEL_VERSION={WHEEL_VERSION}', | ||
| '-DENABLE_WHEEL=ON'] | ||
| f'-DPYTHON_INCLUDE_DIR={python_include_dir}', | ||
| '-DNGRAPH_PYTHON_BUILD_ENABLE=ON', |
There was a problem hiding this comment.
NGRAPH_PYTHON_BUILD_ENABLEis not available anymorePYTHON_EXECUTABLEand similar are replaced withPython3_EXECUTABLE, see Use FindPython3.cmake openvino#19847VERBOSE_BUILDis not available anymore, https://cmake.org/cmake/help/latest/variable/CMAKE_VERBOSE_MAKEFILE.html should be usedENABLE_NVIDIA->BUILD_nvidia_plugin? But anyway, it's not needed since you passed NVIDIA plugin explicitly viaOPENVINO_EXTRA_MODULES- Why is cmake generator explicitly specified? It can be autodetected
There was a problem hiding this comment.
PYTHON_EXECUTABLEand similar are replaced withPython3_EXECUTABLE
Why Python3_EXECUTABLE and not PYTHON3_EXECUTABLE ??
I suggest in future to change from Python3_EXECUTABLE -> PYTHON3_EXECUTABLE for consistency reason
Why is cmake generator explicitly specified? It can be autodetected
It is recommended to use which for detecting proper command path, see https://docs.python.org/3/library/subprocess.html#popen-constructor
There was a problem hiding this comment.
@ilya-lavrenov What is current alternative to plugins.xml ? How external plugin could register currently ?
There was a problem hiding this comment.
I suggest in future to change from Python3_EXECUTABLE -> PYTHON3_EXECUTABLE for consistency reason
You can make this proposal to cmake 😄 https://cmake.org/cmake/help/latest/module/FindPython3.html
It is recommended to use which for detecting proper command path, see
I meant -G option lists makefiles in your case. What if make command is missed, while ninja-build is installed?
How external plugin could register currently ?
As I see you compile NVIDIA plugin with main OpenVINO, which means NVIDIA plugin is not external and plugins.xml is not required.
When plugin is built on top of prebuilt OpenVINO, them plugins.xml is auto-generated and plugin is responsible for its installation.
There was a problem hiding this comment.
I suggest in future to change from Python3_EXECUTABLE -> PYTHON3_EXECUTABLE for consistency reason
You can make this proposal to cmake 😄 https://cmake.org/cmake/help/latest/module/FindPython3.html
Yeah, I thought it is internal OpenVINO option :) Just confused myself )
It is recommended to use which for detecting proper command path, see
I meant
-Goption lists makefiles in your case. What if make command is missed, while ninja-build is installed?
It is related to commands passed to subprocess, which Python tries to find
How external plugin could register currently ?
As I see you compile NVIDIA plugin with main OpenVINO, which means NVIDIA plugin is not external and plugins.xml is not required. When plugin is built on top of prebuilt OpenVINO, them plugins.xml is auto-generated and plugin is responsible for its installation.
Maybe I can compile it with -DENABLE_PLUGINS_XML=ON ?
There was a problem hiding this comment.
It is related to commands passed to subprocess, which Python tries to find
I don't understand how it's connected with subprocesses and Python, maybe I'm missing something. I suppose just need to remove -G to allow cmake to find generator on the system automatically.
Maybe I can compile it with -DENABLE_PLUGINS_XML=ON ?
If you are building whole OpenVINO in this setup.py, then yes - it can be a solution (just to fallback to old behavior)
No description provided.