-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSharp API] Add and init modules.csharp_api project, provide methods for using the CSharp API #733
Conversation
Please add MacOS build script as well since .NET5, .NET6 and later are all cross-platforms |
Hello, thank you very much for your valuable feedback on my CSharp API. I will also make modifications and resubmit it in the near future. However, due to my limited programming skills, there are certain issues with the content of the project I am currently submitting. I will continue to improve my programming skills and further improve the project in the future. |
@guojin-yan Why did you close PR ? |
I am very sorry, but I was not familiar with the process of submitting a PR before because I haven't received a response for so many days. I thought there was a problem with the submitted project, so I closed this PR. Now I will reopen this PR and submit the updates I have made in the past few days. |
@ilya-lavrenov @ilyachur @iefode @nkogteva Could you also look at this one ? |
… handle common models.
@redradist Hello, during this period, I have made further updates to the previous code, improved some interface functions based on the current C API, implemented some indefinite parameter interfaces, and some complex interfaces. At the same time, unit testing has been improved. In this submission, unit testing projects have been added, and over 98% of the interfaces have been tested. |
@ilya-lavrenov @ilyachur @iefode @nkogteva Could you also look at this one again ? |
@ilya-lavrenov Why did you close this PR ? Isn't it needed for OpenVINO to have more programming languages support ? |
The project can live its life, we don't have to merge everything related to OpenVINO to contrib repo. Contrib repo is a sandbox repo, where projects related to OpenVINO can initially live. When the project became more mature, it can be forked to a dedicated repo. Example is OpenVINO Tokenizers All OpenVINO ecosystem projects are listed here https://github.com/openvinotoolkit/awesome-openvino |
@ilya-lavrenov I thought that https://github.com/openvinotoolkit as organization consolidate all ecosystem under its umbrella, otherwise it is hard for user to find C# bindings ... How general user will find |
Maintaining all these projects costs big effort on both infra and development team.
CC @p-wysocki @mlukasze who are working on GFI and consolidating projects in OpenVINO ecosystem. Maybe we can better highlight it in our docs |
Please also to our list of project federated with OpenVINO |
I think you could do it much easier ... Here is how I would did it:
It would bring the following benifits:
Not doing that OpenVINO loosing battle between AI runtimes as for me |
It's not so easy as it seems. All code requires maintenance. |
Choose maintainer not from core team, but from developer which contributed the most. As for me it is that simple ! |
It's quite naive to assume that external contributors can respond within required time slot to perform changes in their components. Such projects are implemented in spare time, which can be absent at the moments when it's really needed. |
Some of them already doing pretty good job like @guojin-yan |
The OpenVINO C # API project is developed based on the OpenVINO official interface C API, and combined with the OpenVINO C++API features, it reconstructs the core, model, sensor, InferRequest and other class objects in C #, implements the C # API and calls OpenVINO in C #.