-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scalar case if "then" and "else" subgraph output are scalar. #28444
Add scalar case if "then" and "else" subgraph output are scalar. #28444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one edge case to consider, beside that LGTM.
The updated logic interprets dynamic PartialShape(Dimension{0, 1})
also as a static single element input, while {0, 1} range for dynamic dimension theoretically means that the tensor is allowed to be empty.
If the fix doesn't require this assumption, I would suggest is_one_element
to return true
for static case only.
In fact dynamic rank should be applicable here, but the "Union of scalar and 1D case" has been added to avoid it, mentioned here #11499 (comment)
…nvinotoolkit#28444) ### Details: - *if "then" and "else" subgraph output shape are scalar, the if node output shape should be static and a scalar* - *...* ### Tickets: - *[28235](openvinotoolkit#28235
Details:
Tickets: