Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for 'dot' tool presence in PATH before calling in VisualizeTree pass and make it debug only #28432

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check for 'dot' tool presence in PATH before calling in VisualizeTree pass and make it debug only #28432

wants to merge 3 commits into from

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Jan 14, 2025 •
edited
Loading

Details:

Check for dot tool availability in PATH before execution:

  • Ensure the Graphviz dot tool is installed and accessible in the system PATH before attempting to execute it
  • If the dot tool is not found, fail gracefully with a clear error message instead of producing the uninformative output: sh: 1: dot: not found
  • Make external 'dot' process call only when ENABLE_OPENVINO_DEBUG define is on
  • Add missing if (VISUALIZE_TESTS_TREE) in tests where VisualizeTree pass is invoked

Tickets:

  • N/A

@aobolensk aobolensk requested a review from a team as a code owner January 14, 2025 09:48
@aobolensk aobolensk requested review from itikhono and removed request for a team January 14, 2025 09:48
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Jan 14, 2025
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Jan 14, 2025
@aobolensk aobolensk changed the title Check for 'dot' tool presence in PATH before calling in VisualizeTree pass Check for 'dot' tool presence in PATH before calling in VisualizeTree pass and make it debug only Jan 14, 2025
@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@itikhono itikhono itikhono approved these changes

Assignees

@itikhono itikhono

Labels
category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aobolensk @ilya-lavrenov @itikhono