NPUW: Support generation & prefill configs extension for npuw::LLMCompiledModel #28413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: NPU
dmatveev
reviewed
Jan 13, 2025
Comment on lines
504
to
505
| merge_config_with(prefill_config, prefill_config_addition_value); | ||
| merge_config_with(generate_config, generate_config_addition_value); |
There was a problem hiding this comment.
Are you sure about the order? Should other_props be taken in first?
There was a problem hiding this comment.
Right argument has prevalence on the left, I think no issues are here
There was a problem hiding this comment.
However, you are right, might be common options should be merged first and them more specific options should be updated
There was a problem hiding this comment.
Well, there is no ++ for common options, it's only applicable for PREFILL_CONFIG and GENERATE_CONFIG
There was a problem hiding this comment.
I think I've got your point now...
AsyaPronina
approved these changes
Jan 13, 2025
AsyaPronina
requested changes
Jan 13, 2025
AsyaPronina
approved these changes
Jan 15, 2025
dmatveev
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.