Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU][ARM] JIT Round Operation #27885

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

emir05051
Copy link
Contributor

@emir05051 emir05051 requested review from a team as code owners December 3, 2024 20:00
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Dec 3, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Dec 3, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like newly added test cases pass on ARM, but fail on x64.
Since Round ops are already covered in common tests https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/tests/functional/shared_tests_instances/single_layer_tests/activation.cpp#L53-L54,
@emir05051 I would propose to remove all changes inside src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/classes/activation.cpp file - that will make CI green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-gorokhov Hi, thank you for your answer. Can you please check if it is okay now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now. Merging!
Thank you for the contribution!

@dmitry-gorokhov
Copy link
Contributor

build_jenkins

@dmitry-gorokhov dmitry-gorokhov added this to the 2025.0 milestone Dec 5, 2024
@dmitry-gorokhov dmitry-gorokhov self-assigned this Dec 5, 2024
@dmitry-gorokhov dmitry-gorokhov added the platform: arm OpenVINO on ARM / ARM64 label Dec 5, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Dec 5, 2024
Merged via the queue into openvinotoolkit:master with commit 9559b42 Dec 5, 2024
170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Round operation
3 participants