Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyOV] OpExtension #27664

Merged
merged 37 commits into from
Jan 14, 2025
Merged

Conversation

akuporos
Copy link
Contributor

@akuporos akuporos commented Nov 21, 2024

Details:

  • Moved DiscretTypeInfoWrapper class from cpp to header.
  • Add new overloading for core.add_extension which takes op class as an argument.
  • Split PyOp to header and implementation
  • Add bindings for OpExtension
  • Add default implementation for get_type_info and clone_with_new_inputs to allow users create a custom operation without adding of these methods.
  • Simplified Op ctor:
    Before (and still working approach):
  def __init__(self, inputs=None):
       super().__init__(self)
       if inputs is not None:
           self.set_arguments(inputs)
           self.constructor_validate_and_infer_types()

After

  def __init__(self, inputs=None):
       super().__init__(self, inputs)

Tickets:

@akuporos akuporos requested review from a team as code owners November 21, 2024 08:58
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools category: OVC OVC tool labels Nov 21, 2024
@akuporos akuporos added this to the 2025.0 milestone Nov 21, 2024
@akuporos akuporos changed the title Akup/py op extension [WIP][PyOV] OpExtension Nov 21, 2024
@akuporos akuporos marked this pull request as draft December 2, 2024 19:52
@akuporos akuporos force-pushed the akup/py-op-extension branch from 1f451ec to 2947d50 Compare December 9, 2024 08:09
@akuporos akuporos force-pushed the akup/py-op-extension branch from 2469726 to ac52233 Compare January 10, 2025 00:52
@akuporos akuporos force-pushed the akup/py-op-extension branch 3 times, most recently from 924e6ab to 948d847 Compare January 10, 2025 11:48
@akuporos akuporos force-pushed the akup/py-op-extension branch from 948d847 to 2caf7e5 Compare January 10, 2025 11:54
@akuporos akuporos enabled auto-merge January 13, 2025 16:34
@akuporos akuporos added this pull request to the merge queue Jan 13, 2025
@akuporos akuporos removed this pull request from the merge queue due to a manual request Jan 13, 2025
@mlukasze mlukasze added this pull request to the merge queue Jan 14, 2025
Merged via the queue into openvinotoolkit:master with commit a0e8de0 Jan 14, 2025
185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: OVC OVC tool category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants