[GPU] Allow unlimited allocations #25955
Open
+108
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-durandin
approved these changes
Aug 7, 2024
sshlyapn
reviewed
Aug 8, 2024
| @@ -3,13 +3,15 @@ | |||
| // | |||
|
|
|||
| #include "intel_gpu/runtime/debug_configuration.hpp" | |||
| #include "intel_gpu/runtime/device.hpp" | |||
There was a problem hiding this comment.
[random spot]
Shouldn't we apply the same extended limit for OpenCL buffers?
cl_mem_flags flags = 0;
flags |= CL_MEM_ALLOW_UNRESTRICTED_SIZE_INTEL;
cl_mem buffer = clCreateBuffer(context, flags, size, host_ptr, errcode_ret);
sshlyapn
reviewed
Aug 8, 2024
| switch (get_allocation_type()) { | ||
| case allocation_type::usm_host: | ||
| _buffer.allocateHost(_bytes_count); | ||
| _buffer.allocateHost(_bytes_count, &properties[0]); |
There was a problem hiding this comment.
Accessing an empty vector (in case of engine->get_device_info().vendor_id == INTEL_VENDOR_ID) at index 0 with operator[] could cause UB probably
And specs say (regarding the properties argument): The list is terminated with the special property 0. So it should be either nullptr or vector with single 0 value by default
vladimir-paramuzov
force-pushed
the
large_allocs
branch
from
2ef733b to
7ef750c
Compare
vladimir-paramuzov
force-pushed
the
large_allocs
branch
from
7ef750c to
63ab88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: