Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Paddle API for ovc tools #23250

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update Paddle API for ovc tools #23250

wants to merge 8 commits into from
+41 −20

Conversation

meiyang-intel
Copy link
Contributor

Details:

  • Update Paddle API for ovc tools

Tickets:

@meiyang-intel meiyang-intel requested a review from a team as a code owner March 4, 2024 12:11
@github-actions github-actions bot added the category: MO Model Optimizer label Mar 4, 2024
@andrei-kochin andrei-kochin requested a review from popovaan March 6, 2024 14:15
popovaan
popovaan reviewed Mar 6, 2024
View reviewed changes
tools/ovc/openvino/tools/ovc/convert_impl.py Outdated
if isinstance(model, paddle.hapi.model.Model) or isinstance(model,
paddle.fluid.dygraph.layers.Layer) or isinstance(
model, paddle.fluid.executor.Executor):
if paddle_model_check_instance(model, "paddle.hapi.model.Model") or paddle_model_check_instance(model, "paddle.nn.layer.layers.Layer") or paddle_model_check_instance(model, "paddle.fluid.dygraph.layers.Layer") or paddle_model_check_instance(model, "paddle.base.Executor") or paddle_model_check_instance(model, "paddle.fluid.executor.Executor"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a list of class names ["paddle.hapi.model.Model", ...] and iterate over them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done.

tools/ovc/openvino/tools/ovc/convert.py Outdated Show resolved Hide resolved
tools/ovc/openvino/tools/ovc/convert.py Outdated Show resolved Hide resolved
@popovaan popovaan requested a review from rkazants March 6, 2024 14:31
@meiyang-intel meiyang-intel requested a review from popovaan March 12, 2024 01:51
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Apr 14, 2024
@yuxu42 yuxu42 added no_stale Do not mark as stale and removed Stale labels Apr 14, 2024
@yuxu42
Copy link
Contributor

yuxu42 commented Apr 14, 2024

@rkazants @popovaan could you please take a review? Thanks!

rkazants
rkazants reviewed Apr 14, 2024
View reviewed changes
Copy link
Member

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Please add tests openvino\tests\layer_tests\ovc_python_api_tests\test_paddle.py to test new model classes.

@meiyang-intel meiyang-intel force-pushed the meiyang/ovc_paddle_update branch from 7faf800 to e5e3ba7 Compare May 14, 2024 05:12
@meiyang-intel meiyang-intel requested a review from a team as a code owner May 14, 2024 05:12
@meiyang-intel meiyang-intel force-pushed the meiyang/ovc_paddle_update branch 2 times, most recently from 40e259e to 41a490f Compare May 14, 2024 06:43
@meiyang-intel meiyang-intel requested a review from a team as a code owner May 14, 2024 06:43
@meiyang-intel meiyang-intel requested review from AlexKoff88 and artanokhov and removed request for a team May 14, 2024 06:43
@github-actions github-actions bot added the category: dependency_changes Pull requests that update a dependency file label May 14, 2024
@meiyang-intel meiyang-intel force-pushed the meiyang/ovc_paddle_update branch from 41a490f to f1cc8c0 Compare May 14, 2024 07:15
@meiyang-intel meiyang-intel requested a review from a team as a code owner May 14, 2024 12:44
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels May 14, 2024
@meiyang-intel meiyang-intel force-pushed the meiyang/ovc_paddle_update branch 2 times, most recently from f215d4f to 358b1bc Compare May 14, 2024 15:52
@ilya-lavrenov ilya-lavrenov added this to the 2024.2 milestone May 14, 2024
@meiyang-intel meiyang-intel force-pushed the meiyang/ovc_paddle_update branch from 358b1bc to 0df82ac Compare May 15, 2024 07:18
@meiyang-intel meiyang-intel force-pushed the meiyang/ovc_paddle_update branch from 0df82ac to 251f671 Compare May 16, 2024 03:19
@ilya-lavrenov ilya-lavrenov removed this from the 2024.2 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants left review comments

@popovaan popovaan Awaiting requested review from popovaan

@AlexKoff88 AlexKoff88 Awaiting requested review from AlexKoff88 AlexKoff88 is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@artanokhov artanokhov Awaiting requested review from artanokhov artanokhov is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: CI OpenVINO public CI category: dependency_changes Pull requests that update a dependency file category: MO Model Optimizer github_actions Pull requests that update GitHub Actions code no_stale Do not mark as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meiyang-intel @yuxu42 @rkazants @popovaan @ilya-lavrenov