Use TRIP_NOT_FOUND when Siri journey cannot be resolved #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5565 +/- ##
==========================================
Coverage 67.21% 67.21%
+ Complexity 16087 16086 -1
==========================================
Files 1852 1852
Lines 71003 70998 -5
Branches 7409 7408 -1
==========================================
Hits 47724 47724
+ Misses 20812 20807 -5
Partials 2467 2467 ☔ View full report in Codecov by Sentry. |
|
Q: To be 100% sure - this only affect the error report for updates? This is not returned on any APIs? |
|
Correct, it only shows up in the Prometheus endpoint. |
jtorin
approved these changes
Dec 14, 2023
t2gran
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When working with a Siri feed in Germany, I noticed that OTP returns a confusing error code when the journey could not be resolved to a trip. This is fixed now.
It also fixes an exception when there is a Siri object that doesn't have a service delivery.