Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add "-Dps" as alias for -P prettierSkip #5557

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Dec 8, 2023

Summary

This work as a short alias to enable this from the command line. To skip
prettier, set the 'ps' system property with the '-D ps' parameter:

# mvn test -D ps

Issue

🟥

Unit tests

🟥

Documentation

✅ Explained in pom file only

Changelog

🟥

Bumping the serialization version id

🟥

@t2gran t2gran added this to the 2.5 (next release) milestone Dec 8, 2023
@t2gran t2gran requested a review from a team as a code owner December 8, 2023 08:47
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28c892d) 67.21% compared to head (3e011bd) 67.21%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5557      +/-   ##
=============================================
- Coverage      67.21%   67.21%   -0.01%     
+ Complexity     16088    16087       -1     
=============================================
  Files           1852     1852              
  Lines          70998    70998              
  Branches        7410     7410              
=============================================
- Hits           47723    47720       -3     
- Misses         20809    20811       +2     
- Partials        2466     2467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pom.xml Outdated Show resolved Hide resolved
Co-authored-by: Leonard Ehrenfried <[email protected]>
@vpaturet vpaturet self-requested a review December 12, 2023 09:52
@t2gran t2gran merged commit 071c412 into opentripplanner:dev-2.x Dec 12, 2023
5 checks passed
@t2gran t2gran deleted the prettier_skip_alias branch December 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants