Use American English [ci skip] #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
force-pushed
the
use_oxford_en_us
branch
from
fd74b98 to
8881802
Compare
t2gran
force-pushed
the
use_oxford_en_us
branch
from
8881802 to
5a98621
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5529 +/- ##
==========================================
Coverage 67.14% 67.14%
+ Complexity 16088 16087 -1
==========================================
Files 1856 1856
Lines 71280 71280
Branches 7465 7465
==========================================
+ Hits 47859 47861 +2
+ Misses 20925 20923 -2
Partials 2496 2496 ☔ View full report in Codecov by Sentry. |
jtorin
approved these changes
Nov 23, 2023
leonardehrenfried
changed the title
leonardehrenfried
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a couple of sentences to the code conventions.
Issue
🟥
Unit tests
🟥
Documentation
✅
Changelog
🟥
Bumping the serialization version id
🟥