Fix serialization of AtomicInteger
#5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
Bug
bump serialization id
leonardehrenfried
force-pushed
the
fix-int-serialization
branch
from
e2771d3 to
8e2e230
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5508 +/- ##
=============================================
+ Coverage 66.87% 66.91% +0.04%
- Complexity 15675 15689 +14
=============================================
Files 1818 1819 +1
Lines 70225 70235 +10
Branches 7390 7392 +2
=============================================
+ Hits 46960 46997 +37
+ Misses 20809 20779 -30
- Partials 2456 2459 +3 ☔ View full report in Codecov by Sentry. |
|
I ran all speed tests and they pass: https://github.com/opentripplanner/OpenTripPlanner/actions/workflows/performance-test.yml?query=branch%3Afix-int-serialization |
t2gran
approved these changes
Nov 15, 2023
optionsome
approved these changes
Nov 15, 2023
t2gran
pushed a commit
that referenced
this pull request
Nov 15, 2023
t2gran
pushed a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #5507 by introducing a custom serializer for
AtomicInteger.Issue
Closes #5507.
Unit tests
The speed tests were run on this branch.
Bumping the serialization version id
✔️