Make feedId required for realtime updaters

[leonardehrenfried]

Summary

@markstos has correctly pointed out that the feedId is incorrectly documented as optional.

This fixes the config schema and docs.

Issue

Closes #5499.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (37a8367) 66.85% compared to head (ff62fd9) 66.85%.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5502      +/-   ##
=============================================
- Coverage      66.85%   66.85%   -0.01%     
+ Complexity     15650    15649       -1     
=============================================
  Files           1817     1817              
  Lines          70158    70155       -3     
  Branches        7379     7379              
=============================================
- Hits           46902    46899       -3     
  Misses         20798    20798              
  Partials        2458     2458              

Files	Coverage Δ
...nfig/updaters/GtfsRealtimeAlertsUpdaterConfig.java	94.44% <100.00%> (-0.80%)	⬇️
...outerconfig/updaters/PollingTripUpdaterConfig.java	95.83% <100.00%> (ø)
...erconfig/updaters/VehicleParkingUpdaterConfig.java	97.91% <100.00%> (ø)
...g/updaters/WebsocketGtfsRealtimeUpdaterConfig.java	88.88% <100.00%> (ø)
...config/updaters/MqttGtfsRealtimeUpdaterConfig.java	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[markstos]

Thanks @leonardehrenfried !

[leonardehrenfried]

This is, BTW, an example of how the code generates the doc, @markstos.

[habrahamsson-skanetrafiken]

This looks good to me. I noticed that the SiriETGooglePubsubUpdaterConfig still takes feedId as optional though. Do you want to fix that as well? @leonardehrenfried

[leonardehrenfried]

I'm not sure if it really is required there. Do you know?

[habrahamsson-skanetrafiken]

We're not using it so I'm not sure. From a glance at the code it looks like the updater will crash if it's null because the EntityResolver needs it.
But maybe fixing that is out of the scope of this PR?

[leonardehrenfried]

I think it is unless someone from Entur chimes in.

[habrahamsson-skanetrafiken]

Ok. Approving!