-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for park and ride itineraries when calculating CO2 emissions #5489
Conversation
src/ext-test/java/org/opentripplanner/ext/emissions/EmissionsTest.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/emissions/EmissionsFilter.java
Outdated
Show resolved
Hide resolved
Please run the formatter. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5489 +/- ##
==========================================
Coverage 66.85% 66.85%
- Complexity 15650 15655 +5
==========================================
Files 1817 1817
Lines 70158 70160 +2
Branches 7379 7383 +4
==========================================
+ Hits 46902 46904 +2
Misses 20798 20798
Partials 2458 2458
☔ View full report in Codecov by Sentry. |
src/ext-test/java/org/opentripplanner/ext/emissions/EmissionsTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my comments.
src/ext-test/java/org/opentripplanner/ext/emissions/EmissionsTest.java
Outdated
Show resolved
Hide resolved
…est.java Co-authored-by: Leonard Ehrenfried <[email protected]>
…est.java Co-authored-by: Leonard Ehrenfried <[email protected]>
src/ext/java/org/opentripplanner/ext/emissions/EmissionsFilter.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/emissions/EmissionsFilter.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/emissions/EmissionsFilter.java
Outdated
Show resolved
Hide resolved
Please resolve the conflicts. |
Summary
Park and ride journeys taken into account in CO2 emission calculations:
Issue
Park and ride journeys receive results based on the car journey alone.
Unit tests
Tests added in file EmissionsServiceTest.java
Tests for:
Manual testing was also performed.