Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GraphQLIntegrationTest less flaky #5481

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Nov 6, 2023

Summary

Since last week we have seen some flaky tests which are due to #5480.

Example: https://github.com/opentripplanner/OpenTripPlanner/actions/runs/6765951122/job/18386315013#step:5:5932

Often it is solved by re-running the tests, which is quite annoying.

This PR attempts to fix it by re-creating new stops which hopefully have an index that is in sync with the current state of StopLocation.INDEX_COUNTER. It's just papering over the problem so we need a proper fix for that.

Issue

Relates to #5480

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35ebd1a) 66.78% compared to head (57e54bd) 66.80%.
Report is 5 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5481      +/-   ##
=============================================
+ Coverage      66.78%   66.80%   +0.02%     
  Complexity     15558    15558              
=============================================
  Files           1806     1806              
  Lines          69842    69822      -20     
  Branches        7357     7357              
=============================================
+ Hits           46643    46647       +4     
+ Misses         20740    20718      -22     
+ Partials        2459     2457       -2     
Files Coverage Δ
...pentripplanner/transit/service/StopModelIndex.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant