Make GraphQLIntegrationTest
less flaky
#5481
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since last week we have seen some flaky tests which are due to #5480.
Example: https://github.com/opentripplanner/OpenTripPlanner/actions/runs/6765951122/job/18386315013#step:5:5932
Often it is solved by re-running the tests, which is quite annoying.
This PR attempts to fix it by re-creating new stops which hopefully have an index that is in sync with the current state of
StopLocation.INDEX_COUNTER
. It's just papering over the problem so we need a proper fix for that.Issue
Relates to #5480