Add logging of siri errors to SiriAzureETUpdater #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5475 +/- ##
=============================================
- Coverage 66.80% 66.80% -0.01%
- Complexity 15557 15561 +4
=============================================
Files 1806 1806
Lines 69821 69830 +9
Branches 7357 7357
=============================================
+ Hits 46646 46648 +2
- Misses 20718 20724 +6
- Partials 2457 2458 +1
☔ View full report in Codecov by Sentry. |
| fuzzyTripMatcher(), | ||
| entityResolver(), | ||
| feedId, | ||
| false, | ||
| updates | ||
| ); | ||
| ResultLogger.logUpdateResult(feedId, "siri-et", result); |
There was a problem hiding this comment.
This is potentially called several times per second for each incoming update. Is that what you want?
There was a problem hiding this comment.
Thanks, you have a point that it might be a bit excessive. We are only interested in the errors really so I updated the PR accordingly.
habrahamsson-skanetrafiken
force-pushed
the
log-azure-siri-errors
branch
from
7aee96b to
35ebd1a
Compare
src/ext/java/org/opentripplanner/ext/siri/updater/azure/SiriAzureETUpdater.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
approved these changes
Nov 6, 2023
Bartosz-Kruba
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add logging and metrics in SiriAzureETUpdater
Also use the service bus endpoint instead of the dataInitializationUrl as the url tag in metrics, since this is the more relevant url.