Orca Fixes Part 2

[daniel-heppner-ibigroup]

Summary

This is just a few more fixes for ORCA agencies

Unit tests

This includes a new test for non ORCA agencies. It needs some more work, but that should go along with a refactor of ItineraryFares to fully utilize Leg Products.

[leonardehrenfried]

Please also run the formatter.

[daniel-heppner-ibigroup]

Thanks for the feedback, it should be ready for another review. @leonardehrenfried

[codecov]

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (9dc111f) 66.84% compared to head (5ca2c88) 66.82%.
Report is 29 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5469      +/-   ##
=============================================
- Coverage      66.84%   66.82%   -0.02%     
- Complexity     15539    15573      +34     
=============================================
  Files           1802     1806       +4     
  Lines          69659    69823     +164     
  Branches        7351     7359       +8     
=============================================
+ Hits           46564    46662      +98     
- Misses         20640    20707      +67     
+ Partials        2455     2454       -1     

Files	Coverage Δ
...ripplanner/framework/tostring/ToStringBuilder.java	100.00% <100.00%> (ø)
...a/org/opentripplanner/model/TimetableSnapshot.java	66.00% <100.00%> (+0.22%)	⬆️
...timization/services/OptimizePathDomainService.java	90.76% <100.00%> (ø)
...fig/routerconfig/updaters/SiriETUpdaterConfig.java	96.55% <100.00%> (+0.55%)	⬆️
...fig/routerconfig/updaters/SiriSXUpdaterConfig.java	96.42% <100.00%> (+0.59%)	⬆️
...org/opentripplanner/transit/model/basic/Money.java	76.47% <100.00%> (+0.47%)	⬆️
...entripplanner/ext/siri/updater/SiriHttpLoader.java	0.00% <0.00%> (ø)
...pentripplanner/ext/fares/impl/OrcaFareService.java	83.19% <83.33%> (+5.83%)	⬆️
...lanner/ext/interactivelauncher/views/MainView.java	0.00% <0.00%> (ø)
.../interactivelauncher/views/StartOtpButtonView.java	0.00% <0.00%> (ø)
... and 12 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.