Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stricter validation for flex areas #5457

Merged

Conversation

vpaturet
Copy link
Contributor

Summary

Currently the graph builder ignores some types of geometry errors when importing NeTEx flex data.
In particular self-intersecting polygons are imported without any validation error:
image

This PR applies a stricter validation when parsing polygons so that invalid areas are rejected (i.e. ignored) during graph building.

Issue

No

Unit tests

Added unit test

Documentation

No

@vpaturet vpaturet self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1331f19) 66.87% compared to head (4d5fc5e) 66.87%.
Report is 1 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5457   +/-   ##
==========================================
  Coverage      66.87%   66.87%           
  Complexity     15495    15495           
==========================================
  Files           1800     1800           
  Lines          69801    69803    +2     
  Branches        7353     7354    +1     
==========================================
+ Hits           46676    46678    +2     
- Misses         20665    20666    +1     
+ Partials        2460     2459    -1     
Files Coverage Δ
...opentripplanner/netex/mapping/FlexStopsMapper.java 86.30% <ø> (-0.19%) ⬇️
...g/opentripplanner/netex/mapping/OpenGisMapper.java 94.73% <100.00%> (+0.98%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vpaturet vpaturet force-pushed the add_stricter_flex_area_validation branch from acc6396 to 4d5fc5e Compare October 27, 2023 09:28
@vpaturet vpaturet marked this pull request as ready for review October 27, 2023 09:31
@vpaturet vpaturet requested a review from a team as a code owner October 27, 2023 09:31
@vpaturet vpaturet merged commit 54c0c0a into opentripplanner:dev-2.x Oct 27, 2023
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 27, 2023
@t2gran t2gran added this to the 2.5 (next release) milestone Oct 27, 2023
@t2gran t2gran deleted the add_stricter_flex_area_validation branch November 21, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants