Make vehicleRentalStation query optionally accept id without feed #5411
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5411 +/- ##
=============================================
- Coverage 66.87% 66.87% -0.01%
Complexity 15496 15496
=============================================
Files 1800 1800
Lines 69793 69801 +8
Branches 7353 7353
=============================================
+ Hits 46674 46676 +2
- Misses 20662 20666 +4
- Partials 2457 2459 +2
☔ View full report in Codecov by Sentry. |
| @@ -304,6 +308,18 @@ private static FareProduct fareProduct(String name) { | |||
| ); | |||
| } | |||
|
|
|||
| @Nonnull | |||
| private static VehicleRentalStation vehicleRentalStation(String name) { | |||
| var station = new VehicleRentalStation(); | |||
There was a problem hiding this comment.
You can use TestVehicleRentalStationBuilder.
| /** | ||
| * This matches station's feedScopedId to the given string. | ||
| */ | ||
| private boolean isMatchRentalStationIds(VehicleRentalStation station, String feedScopedId) { |
There was a problem hiding this comment.
I find this method name a little hard to parse. Can you improve it?
There was a problem hiding this comment.
I completely agree that the method names are awful but I wasn't quite sure if the method name should start with is. Instead of using the word match we could use equal but even then it's as messy. I'm open to suggestions.
There was a problem hiding this comment.
How about matchesStationId or stationIdMatches or stationIdIsMatch?
optionsome
dismissed stale reviews from vesameskanen and leonardehrenfried
via
360fc25
Summary
Adds new feature flag
GtfsGraphQlApiRentalStationFuzzyMatchingto allow matching station ids without feed to ease migration into new query.Issue
Minor change and no issue.
Unit tests
Added tests that existin functionality works
Documentation
Updated OTP config doc
Changelog
Maybe from title or we skip