Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flex transit as a sandbox feature #3121

Closed
wants to merge 8 commits into from

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Jun 25, 2020

This pull request adds the possibility of using flexible transit for access and egress routes. Currently only unscheduled trips are included.

To be completed by pull request submitter:

  • issue: Link to or create an issue that describes the relevant feature or bug. Add GitHub keywords to this PR's description (e.g., closes #45).
  • roadmap: Check the roadmap for this feature or bug. If it is not already on the roadmap, PLC will discuss as part of the review process.
  • tests: Have you added relevant test coverage? Are all the tests passing on the continuous integration service (Travis CI)?
  • formatting: Have you followed the suggested code style?
  • documentation: If you are adding a new configuration option, have you added an explanation to the configuration documentation tables and sections?
  • changelog: add a bullet point to the changelog file with description and link to the linked issue

To be completed by @opentripplanner/plc:

  • reviews and approvals by 2 members, ideally from different organizations
  • after merging: update the relevant card on the roadmap

@t2gran
Copy link
Member

t2gran commented Jul 30, 2020

@hannesj Let me know if you when you want me to review this.

private final Map<Station, MultiModalStation> multiModalStationForStations = Maps.newHashMap();
private final HashGridSpatialIndex<TransitStopVertex> stopSpatialIndex = new HashGridSpatialIndex<>();
private final Map<ServiceDate, TIntSet> serviceCodesRunningForDate = new HashMap<>();
private FlexIndex flexIndex = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be final

@hannesj hannesj mentioned this pull request Sep 1, 2020
8 tasks
.createPoint(v0.getCoordinate());
Envelope env = p.getEnvelopeInternal();
for (FlexStopLocation flexStopLocation : graph.index.getFlexIndex().locationIndex.query(env)) {
if (edge.canTraverse(new TraverseModeSet(TraverseMode.CAR))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for WALK

Comment on lines 9 to 10
public int distance;
public int duration;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to distanceMeters and durationSeconds

@abyrd abyrd added this to the 2.future milestone Oct 13, 2020
@abyrd abyrd removed the OTP2 label Oct 13, 2020
@leonardehrenfried
Copy link
Member

I think this can't be close, can't it?

@hannesj
Copy link
Contributor Author

hannesj commented Mar 22, 2022

I think this can't be close, can't it?

Yes, everything has been implemented, or part of PRs #3456 or #3457

@hannesj hannesj closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants