review: Apply suggestions from review

src/ext/java/org/opentripplanner/ext/siri/ModifiedTripBuilder.java

@@ -34,7 +34,8 @@
  */
 public class ModifiedTripBuilder {
 
-  private static final Logger LOG = LoggerFactory.getLogger(TimetableHelper.class);
+  private static final Logger LOG = LoggerFactory.getLogger(ModifiedTripBuilder.class);
+
   private final TripTimes existingTripTimes;
   private final TripPattern pattern;
   private final LocalDate serviceDate;

src/main/java/org/opentripplanner/api/mapping/TripPlanMapper.java

@@ -21,7 +21,7 @@ public ApiTripPlan mapTripPlan(TripPlan domain) {
     }
     ApiTripPlan api = new ApiTripPlan();
     api.date = Date.from(domain.date);
-    // The origin/destination do not have arrival/depature times; Hence {@code null} is used.
+    // The origin/destination do not have arrival/departure times; Hence {@code null} is used.
     api.from = placeMapper.mapPlace(domain.from, null, null, null, null);
     api.to = placeMapper.mapPlace(domain.to, null, null, null, null);
     api.itineraries = itineraryMapper.mapItineraries(domain.itineraries);

src/main/java/org/opentripplanner/model/plan/pagecursor/readme.md

@@ -18,7 +18,7 @@ moving on to the next.
   request to the next page.  **sw'** is the search window for the new next/previous page. The search
   window may change between requests, so we need to account for it when computing the next/previous
   page cursors.
-- **earliest-departure-time (edt)**  The search-window start with the earliest-depature-time, which
+- **earliest-departure-time (edt)**  The search-window start with the earliest-departure-time, which
   is the first possible time any itinerary may start. **edt'** is the calculated value for the new
   cursor.
 - **latest-arrival-time (lat)**  The latest time an itinerary can arrive to get accepted. The

src/main/java/org/opentripplanner/netex/mapping/TripPatternMapper.java

@@ -363,7 +363,7 @@ private org.opentripplanner.transit.model.network.Route lookupRoute(
   private void createTripTimes(List<Trip> trips, TripPattern tripPattern) {
     for (Trip trip : trips) {
       List<StopTime> stopTimes = result.tripStopTimes.get(trip);
-      if (stopTimes.size() == 0) {
+      if (stopTimes.isEmpty()) {
         issueStore.add(
           "TripWithoutTripTimes",
           "Trip %s does not contain any trip times.",

src/main/java/org/opentripplanner/standalone/config/framework/json/ConfigType.java

@@ -94,7 +94,7 @@ public enum ConfigType {
   TIME_PENALTY(
     JsonType.string,
     """
-        A time-penalty is used to add a penalty to the duration/arrival-time/depature-time for
+        A time-penalty is used to add a penalty to the duration/arrival-time/departure-time for
         a path. It will be invisible to the end user, but used during the routing when comparing
         stop-arrival/paths.
             

src/main/java/org/opentripplanner/transit/model/timetable/ScheduledTripTimes.java

@@ -20,6 +20,12 @@
 import org.opentripplanner.transit.model.framework.Deduplicator;
 import org.opentripplanner.transit.model.framework.DeduplicatorService;
 
+/**
+ * Regular/planed/scheduled read-only version of {@link TripTimes}. The set of static
+ * trip-times are build during graph-build and can not be changed using real-time updates.
+ *
+ * @see RealTimeTripTimes for real-time version
+ */
 public final class ScheduledTripTimes implements TripTimes {
 
   /**
@@ -318,7 +324,7 @@ private void validate() {
   /**
    * When creating scheduled trip times we could potentially imply negative running or dwell times.
    * We really don't want those being used in routing. This method checks that all times are
-   * increasing. The first stop arrival time and the last stops depature time is NOT checked -
+   * increasing. The first stop arrival time and the last stops departure time is NOT checked -
    * these should be ignored by raptor.
    */
   private void validateNonIncreasingTimes() {

src/main/java/org/opentripplanner/transit/model/timetable/TripTimes.java

@@ -23,7 +23,7 @@ public interface TripTimes extends Serializable, Comparable<TripTimes> {
   /**
    * Copy scheduled times, but not the actual times.
    */
-  public RealTimeTripTimes copyScheduledTimes();
+  RealTimeTripTimes copyScheduledTimes();
 
   /** The code for the service on which this trip runs. For departure search optimizations. */
   int getServiceCode();
@@ -59,7 +59,7 @@ public interface TripTimes extends Serializable, Comparable<TripTimes> {
   int getDepartureDelay(int stop);
 
   /**
-   * Whether or not stopIndex is considered a GTFS timepoint.
+   * Whether stopIndex is considered a GTFS timepoint.
    */
   boolean isTimepoint(int stopIndex);