Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor CCE clusters v3 #761

Merged
merged 17 commits into from
Nov 29, 2024
Merged

[Refactor] Refactor CCE clusters v3 #761

merged 17 commits into from
Nov 29, 2024

Conversation

muneeb-jan
Copy link
Member

@muneeb-jan muneeb-jan commented Nov 26, 2024

What this PR does / why we need it

CCE code is using legacy architecture. Most functions such as golangsdk.BuildRequestBody() are depreciated. In this PR, I wish to bring the code up to date with current design and development practices. I also wish to make the code more readable by explicitly specifying the inputs and outputs. Finally, in this PR, the code shall be conformed to API documentation with regards to input and output structs i.e. the function return would be conformed to API response body without the need for extra extract step on part of user.

Which issue this PR fixes

Tests performed

=== RUN   TestListCluster
--- PASS: TestListCluster (0.55s)
=== RUN   TestCluster
--- PASS: TestCluster (405.40s)
=== RUN   TestKubeConfig
--- PASS: TestKubeConfig (434.17s)
PASS

@muneeb-jan muneeb-jan marked this pull request as ready for review November 28, 2024 12:24
Aloento
Aloento previously approved these changes Nov 28, 2024
@muneeb-jan muneeb-jan added the gate Merge PR label Nov 28, 2024
@muneeb-jan muneeb-jan added gate Merge PR and removed gate Merge PR labels Nov 28, 2024
@muneeb-jan muneeb-jan removed the gate Merge PR label Nov 28, 2024
@muneeb-jan muneeb-jan added the gate Merge PR label Nov 28, 2024
@muneeb-jan muneeb-jan removed the gate Merge PR label Nov 28, 2024
@muneeb-jan muneeb-jan requested a review from Aloento November 28, 2024 20:29
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Nov 29, 2024
@otc-zuul otc-zuul bot merged commit 38656d0 into devel Nov 29, 2024
14 checks passed
@otc-zuul otc-zuul bot deleted the refactor-cce-clusters branch November 29, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants