-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor CCE clusters v3 #761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-sidelnikov
temporarily deployed
to
tests
November 28, 2024 11:12 — with
GitHub Actions
Inactive
Aloento
previously approved these changes
Nov 28, 2024
anton-sidelnikov
previously approved these changes
Nov 28, 2024
muneeb-jan
dismissed stale reviews from anton-sidelnikov and Aloento
via
November 28, 2024 15:49
619dec1
anton-sidelnikov
approved these changes
Nov 28, 2024
Aloento
approved these changes
Nov 28, 2024
artem-lifshits
approved these changes
Nov 29, 2024
anton-sidelnikov
temporarily deployed
to
github
November 29, 2024 14:05 — with
GitHub Actions
Inactive
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
CCE code is using legacy architecture. Most functions such as golangsdk.BuildRequestBody() are depreciated. In this PR, I wish to bring the code up to date with current design and development practices. I also wish to make the code more readable by explicitly specifying the inputs and outputs. Finally, in this PR, the code shall be conformed to API documentation with regards to input and output structs i.e. the function return would be conformed to API response body without the need for extra extract step on part of user.
Which issue this PR fixes
Tests performed