first instance livecycle implementation #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-sidelnikov
approved these changes
Aug 6, 2024
artem-lifshits
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds changes for API V2 of Distributed Message Service.
Because of big changes, was approved a decision to create a new v2.1 version for backward compatibility for Terraform.
Which issue this PR fixes
Special notes for your reviewer
Test result:
=== RUN TestDmsLifeCycle
instances_test.go:76: Attempting to create DMSv2 instance
instances_test.go:120: DMSv2 instance successfully created: 75feddfd-3757-47c2-94f9-3cb26efe112f
instances_test.go:197: Attempting to create DMSv2 Topic
instances_test.go:210: DMSv2 Topic successfully created: dms-topic-khXiFlD5
instances_test.go:216: Attempting to update DMSv2 Topic
instances_test.go:56: DMSv2 Topic updated
instances_test.go:232: Attempting to delete DMSv2 Topic
instances_test.go:239: DMSv2 Topic successfully deleted
instances_test.go:137: Attempting to update DMSv2 instance: 75feddfd-3757-47c2-94f9-3cb26efe112f
instances_test.go:147: DMSv2 instance updated successfully: 75feddfd-3757-47c2-94f9-3cb26efe112f
instances_test.go:126: Attempting to delete DMSv2 instance: 75feddfd-3757-47c2-94f9-3cb26efe112f
instances_test.go:133: DMSv1 instance deleted successfully: 75feddfd-3757-47c2-94f9-3cb26efe112f
--- PASS: TestDmsLifeCycle (651.23s)
PASS