Better loop for filter

opentelekomcloud · Jul 1, 2021 · d1f0d9c · d1f0d9c
1 parent a5c2b26
commit d1f0d9c
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/plugins/modules/dcs_instance_statistics_info.py b/plugins/modules/dcs_instance_statistics_info.py
@@ -66,31 +66,24 @@
 
 class DcsInstanceStatisticsInfoModule(OTCModule):
     argument_spec = dict(
-        instance_id=dict(required=False)
+        instance_id=dict(required=False),
     )
     module_kwargs = dict(
         supports_check_mode=True
     )
 
     def run(self):
-        data = []
         final_data = []
 
         for raw in self.conn.dcs.statistics():
             dt = raw.to_dict()
             dt.pop('location')
-            data.append(dt)
-
-        i = 0
-        while i < len(data):
             if self.params['instance_id']:
-                if data[i]['instance_id'] == self.params['instance_id']:
-                    final_data = data[i]
+                if raw.instance_id == self.params['instance_id']:
+                    final_data = dt
                     break
             else:
-                final_data = data
-                break
-            i = i + 1
+                final_data.append(dt)
 
         self.exit(
             changed=False,