Support bootc fixes #858
Merged
Support bootc fixes #858
+135
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slagle
requested review from
bshephar
and removed request for
booxter and
karelyatin
Closed
slagle
force-pushed
the
support-bootc-fixes
branch
2 times, most recently
from
fa18d58 to
0bdd610
Compare
This change writes systemd files to etc instead of /usr/share along with adding support for Python libraries baked into the bootc image. Signed-off-by: Brendan Shephard <[email protected]>
This change moves the script we're using for the logs cronjob into the /var/lib/openstack/cron directory. This facilitates the bootc immutable filesystem where we can't write to /usr, while also consolidating scripts relevant to our deployment in a common place. Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
This change skips any calls to dnf on bootc nodes since they are expected to fail. Signed-off-by: Brendan Shephard <[email protected]>
The edpm_kernel tasks are skipped for the time being when using bootc. Signed-off-by: James Slagle <[email protected]>
The script can't be installed to /usr/libexec when using bootc. Use /var/local/libexec instead. Signed-off-by: James Slagle <[email protected]>
/etc/localtime does not exist by default in bootc images. Since the logrotate_crond container assumes it exists to use a volume mount, it must be created if it doesn't exist. Signed-off-by: James Slagle <[email protected]>
Signed-off-by: James Slagle <[email protected]>
Add tasks to the test_deps role for molecule. That tasks will ensure the custom fact exists. The test_deps_bootc_fact variable can be used to control the value of the fact. Signed-off-by: James Slagle <[email protected]>
Signed-off-by: James Slagle <[email protected]>
These tasks run with "become: true", so the /var/lib/openstack dir should be root owned, just like the scripts created in the dir. Also correct the path to the tmpwatch script when it is set in the crontab, and in the molecule verify.yml. Signed-off-by: James Slagle <[email protected]>
slagle
force-pushed
the
support-bootc-fixes
branch
from
0bdd610 to
a590bf7
Compare
bshephar
approved these changes
Jan 22, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 508fd24
into
openstack-k8s-operators:bootc
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: OSPRH-11110