Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip molecule test for unmodified roles #854

Merged

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Jan 16, 2025

closes OSPRH-11820

@openshift-ci openshift-ci bot requested review from slagle and stuggi January 16, 2025 00:27
@fao89 fao89 force-pushed the zOSPRH-11820 branch 3 times, most recently from 7d4d1fd to c1fedb2 Compare January 16, 2025 00:55
closes OSPRH-11820

Signed-off-by: Fabricio Aguiar <[email protected]>
@fao89 fao89 force-pushed the zOSPRH-11820 branch 3 times, most recently from abae409 to ca847a3 Compare January 16, 2025 01:08
@fao89 fao89 requested review from rabi and bshephar and removed request for stuggi January 16, 2025 01:11
Copy link
Contributor

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -14,71 +14,99 @@
- job:
name: edpm-ansible-molecule-edpm_bootstrap
parent: edpm-ansible-molecule-base
files:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does setting it in the parent with the TEST_RUN var not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, but it didn't work

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a32a9d2 into openstack-k8s-operators:main Jan 16, 2025
6 checks passed
@fao89
Copy link
Contributor Author

fao89 commented Jan 23, 2025

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@fao89: #854 failed to apply on top of branch "18.0-fr1":

Applying: Skip molecule test for unmodified roles
Using index info to reconstruct a base tree...
M	zuul.d/jobs.yaml
Falling back to patching base and 3-way merge...
Auto-merging zuul.d/jobs.yaml
CONFLICT (content): Merge conflict in zuul.d/jobs.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Skip molecule test for unmodified roles

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants