Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test modified roles #853

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Jan 14, 2025

closes OSPRH-11820

@fao89 fao89 force-pushed the OSPRH-11820 branch 3 times, most recently from 7d765d9 to a7322b7 Compare January 14, 2025 16:56
@fao89 fao89 requested review from rabi, bshephar and slagle and removed request for lewisdenny and frenzyfriday January 14, 2025 17:03
- name: Check whether the role is modified
id: check_role
run: |
if [[ $(git diff --name-only roles | grep ${{ matrix.tested_role }}) ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you grep for the role name followed by a / here, then you won't get substring matches. For instance, edpm_telemetry would also match edpm_telemetry_logging with the way it is now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

closes OSPRH-11820

Signed-off-by: Fabricio Aguiar <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aa0a2e2 into openstack-k8s-operators:main Jan 15, 2025
34 checks passed
@fao89
Copy link
Contributor Author

fao89 commented Jan 23, 2025

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@fao89: new pull request created: #860

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants