-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only test modified roles #853
Only test modified roles #853
Conversation
7d765d9
to
a7322b7
Compare
.github/workflows/molecule.yaml
Outdated
- name: Check whether the role is modified | ||
id: check_role | ||
run: | | ||
if [[ $(git diff --name-only roles | grep ${{ matrix.tested_role }}) ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you grep for the role name followed by a /
here, then you won't get substring matches. For instance, edpm_telemetry would also match edpm_telemetry_logging with the way it is now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
closes OSPRH-11820 Signed-off-by: Fabricio Aguiar <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aa0a2e2
into
openstack-k8s-operators:main
/cherry-pick 18.0-fr1 |
@fao89: new pull request created: #860 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
closes OSPRH-11820