Making check for mandatory ovs_dpdk parms #848
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vcandapp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vcandapp
requested review from
Jaganathancse
and removed request for
lewisdenny and
abays
| - name: Check valid input for edpm_ovs_dpdk_socket_memory | ||
| ansible.builtin.fail: | ||
| msg: "Socket Memory cannot be empty - edpm_ovs_dpdk_socket_memory" | ||
| when: not edpm_ovs_dpdk_socket_memory|string or edpm_ovs_dpdk_socket_memory == 'null' |
There was a problem hiding this comment.
@vcandapp edpm_ovs_dpdk_socket_memory is "" default, so null check is not required.
Instead of failing, can we make default value for this parameter edpm_ovs_dpdk_socket_memory ?
There was a problem hiding this comment.
https://github.com/openstack-archive/tripleo-ansible/blob/stable/wallaby/tripleo_ansible/playbooks/cli-overcloud-openvswitch-dpdk.yaml#L22, even though they are mandatory - it is set to NULL
There was a problem hiding this comment.
Like in earlier deployment, https://github.com/openstack-archive/tripleo-ansible/blob/stable/wallaby/tripleo_ansible/playbooks/cli-overcloud-openvswitch-dpdk.yaml#L22 we set it to NULL even for mandatory params
| @@ -22,7 +21,6 @@ argument_specs: | |||
| description: OvS DPDK extra configs | |||
| edpm_ovs_dpdk_socket_memory: | |||
| type: str | |||
| default: "" | |||
There was a problem hiding this comment.
@vcandapp
Need to remove in default main.yaml file if we need to remove default value.
|
recheck |
No description provided.