Stop and disable iscsi-starter.service #846
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi
reviewed
Dec 13, 2024
roles/edpm_iscsid/tasks/install.yml
Outdated
| - ansible_facts.services["iscsi.service"] is defined | ||
| - ansible_facts.services["iscsi.service"]["status"] != "not-found" | ||
| - ansible_facts.services["iscsi.service"]["status"] == "enabled" | ||
| - ansible_facts.services["item"] is defined |
There was a problem hiding this comment.
I guess you've to remove the quotes from "item" here.
roles/edpm_iscsid/tasks/install.yml
Outdated
| loop: | ||
| - iscsi.service | ||
| - iscsi-starter.service | ||
|
|
When an EDPM node rebooted which runs a VM with iscsi-backed volume, it leaves node records under /var/lib/iscsi/nodes. While the records exist, iscsi-starter.service runs iscsi.service. Then it starts iscsid.service also. To prevent this issue, we need to stop and disable iscsi-starter.service. Signed-off-by: Keigo Noha <[email protected]>
knoha-rh
force-pushed
the
disable-iscsi-starter
branch
from
18a3231 to
8d723ce
Compare
bshephar
approved these changes
Dec 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, knoha-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ef3c633
into
openstack-k8s-operators:main
34 checks passed
|
/cherrypick 18.0-fr1 |
|
@knoha-rh: new pull request created: #847 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sbekkerm
pushed a commit
to sbekkerm/edpm-ansible
that referenced
this pull request
Dec 25, 2024
…iscsi-starter Stop and disable iscsi-starter.service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an EDPM node rebooted which runs a VM with iscsi-backed volume,
it leaves node records under /var/lib/iscsi/nodes.
While the records exist, iscsi-starter.service runs iscsi.service.
Then it starts iscsid.service also.
To prevent this issue, we need to stop and disable iscsi-starter.service.
JIRA:OSPRH-12372