Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdline reading issue in kernel args #486

Merged
merged 1 commit into from
Nov 21, 2023
Merged

cmdline reading issue in kernel args #486

merged 1 commit into from
Nov 21, 2023

Conversation

Jaganathancse
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from dprince and olliewalsh November 7, 2023 09:12
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e17b82c2aadb4a23a09fc624ca6caf33

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 43s
❌ podified-multinode-edpm-deployment-crc FAILURE in 51m 28s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 24s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 44s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 16s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 33s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 18s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 28s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 39s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 53s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 06s

@Jaganathancse
Copy link
Contributor Author

/retest

jpodivin
jpodivin requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please point to the issue this is supposed to solve? As it is I have no idea.

@Jaganathancse
Copy link
Contributor Author

Jaganathancse commented Nov 15, 2023 •
edited
Loading

Could you please point to the issue this is supposed to solve? As it is I have no idea.
@jpodivin
Save decoded cmdline task provides cmdline output as json format and does not have field like stdout or stdout_lines.

edpm-ansible/roles/edpm_kernel/tasks/kernelargs.yml

Line 24 in 865dadc

cmdline: "{{ cmdline_encoded['content'] | b64decode }}"

So placed patch to fix the issues in updated tasks.

@jpodivin
Copy link
Contributor

Ok. Could you please put that in the commit msg?

cmdline reading issue in kernel args
5bc88bf 
Save decoded cmdline task provides cmdline
output as json format and does not have
field like stdout or stdout_lines.
@Jaganathancse Jaganathancse force-pushed the cmdline_issue_kernel_args branch from 865dadc to 5bc88bf Compare November 21, 2023 10:38
@Jaganathancse
Copy link
Contributor Author

Ok. Could you please put that in the commit msg?
@jpodivin Done.

@jpodivin jpodivin self-requested a review November 21, 2023 12:55
@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jaganathancse, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec0202b into openstack-k8s-operators:main Nov 21, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpodivin jpodivin jpodivin approved these changes

@dprince dprince Awaiting requested review from dprince

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@jpodivin jpodivin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaganathancse @jpodivin