Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for extra OVN cluster per node for ovn-bgp-agent #477

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add initial support for extra OVN cluster per node for ovn-bgp-agent #477

merged 1 commit into from
Nov 27, 2023

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Oct 25, 2023

No description provided.

@openshift-ci openshift-ci bot requested review from lewisdenny and rabi October 25, 2023 07:48
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e68b945dd0304de0a53c36793f05417b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 44s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 28m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 40s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 09s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 12s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 38s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 16s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 14s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 10s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 50s
❌ edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 8m 56s

@luis5tb luis5tb force-pushed the bgp-ovn-cluster branch 4 times, most recently from ca4e961 to e325adf Compare November 13, 2023 09:06
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8dc80c3d8f5c4a22b6e551edcd3c2e36

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 28m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 08s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 33s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 59s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 29s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 43s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 09s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 56s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 39s
❌ edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 7m 33s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/dbf7624a50504b40a1e789ff5db92f2f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 07s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 39m 32s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 02s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 27s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 07s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 47s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 11s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 26s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 28s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 31s
❌ edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 8m 36s

@luis5tb luis5tb force-pushed the bgp-ovn-cluster branch 5 times, most recently from c793676 to 716ffee Compare November 17, 2023 11:44
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1414d736be054b28b69172c6d9206d0c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 05s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 06m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 20s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 56s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 03s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 05s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 17s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 21s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 56s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 52s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 35s

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 20, 2023

recheck seems to be an unrelated error

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2d555635610542669d4704f6a417b685

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 28m 37s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 57s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 37s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 07s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 38s
❌ edpm-ansible-molecule-edpm_libvirt NODE_FAILURE Node request 200-0006653326 failed in 0s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 55s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 38s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 38s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 13s

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 20, 2023

recheck nodefailure

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3045b6b36fea4bb8a8bc362bbdcdc302

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 32m 34s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 52m 58s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 41s
❌ edpm-ansible-molecule-edpm_module_load NODE_FAILURE Node request 200-0006654071 failed in 0s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 28s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 52s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 08s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 59s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 48s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 28s

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 21, 2023

recheck node failure

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/92887cd909944dcbbf7add1e76d69019

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 34m 46s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 53m 58s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 40s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 47s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 36s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 14s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 23s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 00s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 55s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 49s

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 22, 2023

recheck unrelated as it failed before edpm-ansible

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5d1ebeded38a4815a8d4184205183bc9

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 200-0006664264 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 51s
❌ edpm-ansible-molecule-edpm_module_load NODE_FAILURE Node request 200-0006664266 failed in 0s
❌ edpm-ansible-molecule-edpm_kernel NODE_FAILURE Node request 200-0006664267 failed in 0s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 06s
❌ edpm-ansible-molecule-edpm_nova NODE_FAILURE Node request 200-0006664269 failed in 0s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 12s
❌ edpm-ansible-molecule-edpm_iscsid NODE_FAILURE Node request 200-0006664271 failed in 0s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 34s

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 23, 2023

recheck node_failure

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/027d4a7fab3640e4a007b992f64df975

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 200-0006664330 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
❌ edpm-ansible-molecule-edpm_podman NODE_FAILURE Node request 200-0006664331 failed in 0s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 28s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 44s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 16s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 33s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 18s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 07s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 45s

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 23, 2023

/test pre-commit-test

rebtoor
rebtoor reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a couple of comments to address, but i'm ok with this role. I'd wait for another couple of eyes before approving it.

roles/edpm_ovn_bgp_agent/tasks/configure.yml Outdated Show resolved Hide resolved
roles/edpm_ovn_bgp_agent/tasks/configure_ovn.yml Outdated Show resolved Hide resolved
@fao89 fao89 requested review from booxter and karelyatin November 24, 2023 09:25
@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 24, 2023

First we need openstack-k8s-operators/dataplane-operator#539

@luis5tb luis5tb force-pushed the bgp-ovn-cluster branch 2 times, most recently from 1c7203a to 3ffc4ca Compare November 24, 2023 12:48
@rebtoor
Copy link
Contributor

rebtoor commented Nov 24, 2023

@luis5tb can you squash your commits in a single commit so we can keep our history clean? Thanks!

@rebtoor
Copy link
Contributor

rebtoor commented Nov 24, 2023

First we need openstack-k8s-operators/dataplane-operator#539

Please, add a Depends-on in the pr description and put this PR on hold (until the other pr will be merged) to avoid issues.

@luis5tb luis5tb force-pushed the bgp-ovn-cluster branch 2 times, most recently from c174c58 to caf1251 Compare November 24, 2023 14:43
@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 24, 2023

First we need openstack-k8s-operators/dataplane-operator#539

Please, add a Depends-on in the pr description and put this PR on hold (until the other pr will be merged) to avoid issues.

done

@luis5tb luis5tb changed the title Add initial support for extra OVN cluster per node for ovn-bgp-agent [WIP] Add initial support for extra OVN cluster per node for ovn-bgp-agent Nov 24, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/838458ffa19b46ebb7959e1de642bd01

❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 9s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 52s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 31s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 55s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 32s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 51s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 11s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 29s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 9m 07s

@luis5tb luis5tb changed the title [WIP] Add initial support for extra OVN cluster per node for ovn-bgp-agent Add initial support for extra OVN cluster per node for ovn-bgp-agent Nov 27, 2023
@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 27, 2023

retest dataplane-operator patch merged

@luis5tb
Copy link
Contributor Author

luis5tb commented Nov 27, 2023

recheck

@luis5tb
Add initial support for extra OVN cluster per node for ovn-bgp-agent
f45a123 
This also includes:
- support for using secret for ovn DBs connection
- adaptation for the new location of the OVN DBs config option
  in the ovn-bgp-agent [1]

Depends-on openstack-k8s-operators/dataplane-operator#539

[1] https://review.opendev.org/c/openstack/ovn-bgp-agent/+/901597
@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, luis5tb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8888a9e into openstack-k8s-operators:main Nov 27, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fao89 fao89 fao89 approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@rabi rabi Awaiting requested review from rabi

@booxter booxter Awaiting requested review from booxter

@rebtoor rebtoor Awaiting requested review from rebtoor

@karelyatin karelyatin Awaiting requested review from karelyatin

Assignees

@fao89 fao89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luis5tb @rebtoor @fao89 @karelyatin