Making check for mandatory parms

openstack-k8s-operators · Jan 3, 2025 · 11ceb30 · 11ceb30
1 parent ef3c633
commit 11ceb30
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/roles/edpm_ovs_dpdk/meta/argument_specs.yml b/roles/edpm_ovs_dpdk/meta/argument_specs.yml
@@ -6,7 +6,6 @@ argument_specs:
     options:
       edpm_ovs_dpdk_pmd_core_list:
         type: str
-        default: ""
         description: OvS DPDK PMD Core list
       edpm_ovs_dpdk_lcore_list:
         type: str
@@ -22,7 +21,6 @@ argument_specs:
         description: OvS DPDK extra configs
       edpm_ovs_dpdk_socket_memory:
         type: str
-        default: ""
         description: OvS DPDK Socket Memory
       edpm_ovs_dpdk_revalidator_cores:
         type: str

diff --git a/roles/edpm_ovs_dpdk/tasks/configure.yml b/roles/edpm_ovs_dpdk/tasks/configure.yml
@@ -19,6 +19,11 @@
     msg: "List of PMD cores cannot be empty - edpm_ovs_dpdk_pmd_core_list"
   when: not edpm_ovs_dpdk_pmd_core_list|string or edpm_ovs_dpdk_pmd_core_list == 'null'
 
+- name: Check valid input for edpm_ovs_dpdk_socket_memory
+  ansible.builtin.fail:
+    msg: "Socket Memory cannot be empty - edpm_ovs_dpdk_socket_memory"
+  when: not edpm_ovs_dpdk_socket_memory|string or edpm_ovs_dpdk_socket_memory == 'null'
+
 - name: PMD cores config
   when: edpm_ovs_dpdk_pmd_core_list|string
   block: