Check the stat dictionary's size, not the variable's size #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,4 +23,4 @@ | |||
| TOX_CONSTRAINTS_FILE: "{{ constraints_file.path }}" | |||
| # Backward compatibility, to be removed | |||
| UPPER_CONSTRAINTS_FILE: "{{ constraints_file.path }}" | |||
| when: constraints_stat.size > 0 | |||
| when: constraints_file is defined and constraints_stat.size > 0 | |||
There was a problem hiding this comment.
The above condition looks good but more appropriate can be to use constraints_stat.exists
freyes
requested changes
Feb 16, 2024
| @@ -23,4 +23,4 @@ | |||
| TOX_CONSTRAINTS_FILE: "{{ constraints_file.path }}" | |||
| # Backward compatibility, to be removed | |||
| UPPER_CONSTRAINTS_FILE: "{{ constraints_file.path }}" | |||
| when: constraints_stat.size > 0 | |||
| when: constraints_file is defined and constraints_stat.size > 0 | |||
There was a problem hiding this comment.
it should be constraints_stat.stat.size, it's still missing the .stat
There was a problem hiding this comment.
I just pushed a new revision of the change to address this.
The ansible.builtin.stat module returns a dictionary where the key to use is 'stat' in order to get the file stats. Add the missing stat key. Failure to do this causes the task to fail with size not being a key in the dictionary. ref: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/stat_module.html#ansible-collections-ansible-builtin-stat-module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ansible.builtin.stat module returns a dictionary where the key to use is 'stat' in order to get the file stats. Add the missing stat key. Failure to do this causes the task to fail with size not being a key in the dictionary.
ref: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/stat_module.html#ansible-collections-ansible-builtin-stat-module