Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --file when running juju model-defaults #318

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Pass --file when running juju model-defaults #318

merged 1 commit into from
Feb 13, 2024

Conversation

freyes
Copy link
Member

@freyes freyes commented Feb 13, 2024

Juju>=3.0 added the --file flag when passing the default values for a model in a yaml file.

This change checks the juju client's version using dpkg --compare-versions.

@freyes
Pass --file when running juju model-defaults
202a3ad 
Juju>=3.0 added the `--file` flag when passing the default values for a
model in a yaml file.

This change checks the juju client's version using `dpkg
--compare-versions`.
wolsen
wolsen approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@wolsen wolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is whether or not Juju will continue to have dpkg comparable versions, however we know for now that is the case. As such, LGTM.

@wolsen wolsen merged commit 584e9e6 into openstack-charmers:master Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolsen wolsen wolsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freyes @wolsen