Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server version, date created and date edited to Practitioner and Organization Resources #1047

Merged

Conversation

allan-on
Copy link
Contributor

ndegwamartin
ndegwamartin previously approved these changes Feb 9, 2022
import static org.opensrp.web.Constants.PAGE_NUMBER;
import static org.opensrp.web.Constants.PAGE_SIZE;
import static org.opensrp.web.Constants.TOTAL_RECORDS;
import static org.opensrp.web.Constants.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid wildcard imports

import static org.opensrp.web.Constants.ORDER_BY_TYPE;
import static org.opensrp.web.Constants.PAGE_NUMBER;
import static org.opensrp.web.Constants.PAGE_SIZE;
import static org.opensrp.web.Constants.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid wild card imports


@Controller
@RequestMapping(value = "/rest/practitioner")
public class PractitionerResource {

private static Logger logger = LogManager.getLogger(PractitionerResource.class.toString());

public static Gson gson = new GsonBuilder().registerTypeAdapter(DateTime.class, new TaskDateTimeTypeConverter())
.registerTypeAdapter(LocalDate.class, new DateTypeConverter()).create();
public static Gson gson = new GsonBuilder().setDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the date format be moved to a constant (constants file)

bennsimon and others added 2 commits February 10, 2022 13:51
* update dependencies to fix security vulnerabilities

* update swaggerConfig test

* fix organizationResourceTests

* update DiskSpaceMetrics package
@hilpitome hilpitome requested a review from Rkareko February 21, 2022 20:07
@allan-on allan-on merged commit f9ea827 into master Feb 22, 2022
@allan-on allan-on deleted the 521-add-practitioner-org-server-version-last-edited-updated branch February 22, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants