-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43427: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.30 into release-4.17 #314
base: release-4.17
Are you sure you want to change the base?
Conversation
* fix ovn security groups * add tlscontainerref
* prepare release 1.30.2 * update deps * use k8s 1.30.7 * Fix CSI tests (kubernetes#2712) * [tests] bump devstack branch to stable/2023.2, fix python issues (kubernetes#2716) * [tests] bump ubuntu to 24.04 jammy (kubernetes#2721) --------- Co-authored-by: pýrus <[email protected]>
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
/retest-required |
* Stop setting GOPROXY in Dockerfile We're seeing failures in CI related to goproxy.io. There's no need to set this so simply don't. Signed-off-by: Stephen Finucane <[email protected]> * test: Remove use of global_env fact It's confusing and unnecessary. Place everything in its regular place instead. Signed-off-by: Stephen Finucane <[email protected]> * tests: Don't rely on GOPATH This wasn't being set correctly and managing envvars via Ansible is tricky at the best of times. Use hard coded paths instead. Signed-off-by: Stephen Finucane <[email protected]> * tests: Set environment While we figure out why bashrc is not being respected. Signed-off-by: Stephen Finucane <[email protected]> --------- Signed-off-by: Stephen Finucane <[email protected]> Co-authored-by: Stephen Finucane <[email protected]>
…1.30 into release-4.17
88612af
to
256d017
Compare
@shiftstack-merge-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retitle OCPBUGS-43427: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.30 into release-4.17 |
@shiftstack-merge-bot[bot]: This pull request references Jira Issue OCPBUGS-43427, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@EmilienM: This pull request references Jira Issue OCPBUGS-43427, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backport-risk-assessed
/jira refresh |
@EmilienM: This pull request references Jira Issue OCPBUGS-43427, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre, shiftstack-merge-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.